Pipe Symbol "|" in a Song Name causes it to crash

Bug report

Checklist

• I have searched for similar bugs in the issues.
• I will add the bug label to this issue.

Version Info

• Ytmdl version: 2022.03.16
• Youtube-dl version: Not Installed

How Ytmdl was installed?

Installed on Windows 10 using pip Python Version: 3.10.2 Pip Version: pip 22.0.3

Console Log

> ytmdl https://www.youtube.com/watch?v=GADlWyHaMmI --level DEBUG
 ==> Logger running in DEBUG mode
 ==> Passed args: Namespace(SONG_NAME=['https://www.youtube.com/watch?v=GADlWyHaMmI'], quiet=False, output_dir=None, song=None, choice=None, artist=None, album=None, disable_metaadd=False, skip_meta=False, manual_meta=False, itunes_id=None, spotify_id=None, disable_sort=False, ask_meta_name=False, on_meta_error=None, proxy=None, url=None, list=None, nolocal=False, format='mp3', trim=False, get_opts=False, keep_chapter_name=False, download_archive=None, ignore_chapters=False, ytdl_config=None, pl_start=None, pl_end=None, pl_items=None, ignore_errors=False, title_as_name=False, level='DEBUG', disable_file=False, list_level=False)
 ==> on_meta_error before:  None
 ==> on_meta_error after:  exit
 ==> itunes_country: US
 ==> ['https://www.youtube.com/watch?v=GADlWyHaMmI']
 ==> https://www.youtube.com/watch?v=GADlWyHaMmI
 ==> None
 ==> Searching to see if already present in C:\Users\Root\Music
 ==> proxy passed: None
 ==> Passed format: mp3
 ==> Searching Youtube for https://www.youtube.com/watch?v=GADlWyHaMmI
 ==> Choose One (One with [M] is verified music)
 [1] Coke Studio | Season 14 | Pasoori | Ali Sethi x Shae Gill by Music Vibes Zone with dur 4:29
 [2] Gandhari Dance Cover | vaishnavi | Full song dance | Keerthy Suresh | Pawan CH | Suddala Ashok Teja by vaishnavi varnika with dur 3:16
 ==> Enter Choice (1): 1
 ==> 1
 ==> Downloading Coke Studio | Season 14 | Pasoori | Ali Sethi x Shae Gill in 320kbps
 ==> Saving the files to: C:\Users\Root\.cache\ytmdl
 ==> C:\Users\Root\.cache\ytmdl\Coke#Studio#|#Season#14#|#Pasoori#|#Ali#Sethi#x#Shae#Gill.mp3
 ==> Enabling progress hook.
 ==> Passed value for no_progress: False
[youtube] GADlWyHaMmI: Downloading webpage
[youtube] GADlWyHaMmI: Downloading android player API JSON
[info] GADlWyHaMmI: Downloading 1 format(s): 251
[download] Destination: C:\Users\Root\.cache\ytmdl\Coke#Studio###Season#14###Pasoori###Ali#Sethi#x#Shae#Gill.mp3
[download] 100% of 4.45MiB in 00:00
 ==> Downloaded!
[youtube] GADlWyHaMmI: Downloading webpage
[youtube] GADlWyHaMmI: Downloading android player API JSON
 ==> [{}]
 ==> song_name:  Coke Studio | Season 14 | Pasoori | Ali Sethi x Shae Gill  song_meta:  https://www.youtube.com/watch?v=GADlWyHaMmI
 ==> None
 ==> None:None
 ==> Skip Meta: False
 ==> Getting song data for https://www.youtube.com/watch?v=GADlWyHaMmI...
 ==> Searching metadata with itunes
 ==> No results found with the keyword https://www.youtube.com/watch?v=GADlWyHaMmI
 ==> Something went wrong with iTunes. The program will continue withthe other providers. Please check '[C:\Users\Root\.cache\ytmdl\logs\log.cat]' for more details.
 ==> Searching metadata with gaana
 ==> Searching metadata with spotify
 ==> Using US for Spotify country
 ==> ext: mp3
 ==> Moving to: C:\Users\Root\Music
 ==> [Errno 22] Invalid argument: 'C:\\Users\\Root\\.cache\\ytmdl\\Coke#Studio#|#Season#14#|#Pasoori#|#Ali#Sethi#x#Shae#Gill.mp3_new.mp3'
 ==> No metadata found for `https://www.youtube.com/watch?v=GADlWyHaMmI` . Pass `--ignore-errors` or `on-meta-error` to ignore this.

Description

If there’s a pipe symbol | in a song name, it will download it, but will cause an error while moving it to current directory.

==> [Errno 22] Invalid argument: ‘C:\Users\Root\.cache\ytmdl\Coke#Studio#|#Season#14#|#Pasoori#|#Ali#Sethi#x#Shae#Gill.mp3_new.mp3’

Screenshots

With Pipe Symbol

Sample URL

https://www.youtube.com/watch?v=GADlWyHaMmI

Without Pipe Symbol

Sample URL

https://www.youtube.com/watch?v=7ypyKG4Iu5k

[deepjyoti30]

@wh0th3h3llam1 Thanks for confirming. Seems like these characters are not properly blacklisted for Windows. For Linux, this was an issue reported way back and was taken care of way back.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for another 7 days. Thank you for your contributions.