question: what is unified cli input?

Hiya!

I am excited to see support for deps.exe (as clojure.exe) on Windows. Thanks so much for adding that as a feature!

The current README suggests selecting via:

  cmd-exe-workaround: 'latest' # Replaces `clojure` with `deps.clj` on Windows

But the source code sez cmd-exe-workaround is deprecated https://github.com/DeLaGuardo/setup-clojure/blob/3199aaaa9cf140bcb7a5f36a72d1aa42658ee991/action.yml#L17-L24

But I don’t know what a “unified cli input” is.

Let’s say I have a matrix build for macOS, Windows, and Linux, how should I select deps.exe (as clojure.exe) for windows?

[borkdude]

Well, I think that is mostly the case since deps.clj as a binary it solves a problem on Windows mostly.

[lread]

The exit code for PowerShell launches directly from GitHub Actions is handled properly, but if you call clojure yourself from a script you have to be aware of this:

TIL, (I am powershell naive, so maybe obvious to most of you): If you run powershell -command my-command the exit code from my-command is not returned to the caller. For that you need tag on an exit $LASTEXITCODE, like: powershell -command "my-command;exit $LASTEXITCODE" Kind of important if you are wanting to know about little things like test failures.

I don’t have specific examples of escaping woes, but I’ve felt them.

I do see an old slack post from me about me about trying to install clojure core team cli:

For what it is worth, I had a pleasant experience experimenting with @borkdude’s deps.clj (using its deps.exe) when setting up testing of rewrite-cljc on GitHub Actions on Windows. I was even bold enough to rename deps.exe to clojure.exe. I did initially try installing the official alpha Clojure PowerShell module, but GitHub Actions did not see the module, so I gave up, admittedly, rather quickly. Using a renamed deps.clj allowed me the luxury of calling clojure easily from any shell.

I think you’ve solved the installation part of this problem with your setup-clojure Action, but not the easily “runnable from any shell” part.

If you want a blurb for the README, maybe something like?:

cmd-exe-workaround

Some people bump into challenges using the clojure core team alpha cli on Windows because it is runnable only from Powershell. Launching a Powershell module from a script can make such things as argument escaping and exit code capturing extra tricky. For these people, we offer cmd-exe-workaround to instead install borkdude/deps.clj’s deps.exe as clojure.exe when on Windows.