Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

CI/tests: use tox?

See original GitHub issue

I think it is very useful to have a tox.ini to run tests in an isolated way. This would also allow for using tox-travis on Travis then.

What is your opinion? I’d be happy to provide a PR for this.

Issue Analytics

State:
Created 5 years ago
Reactions:2
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

Delgancommented, Jan 20, 2019

Cool. I will also add some flake8 and pytest settings along the way: do you prefer to have them in setup.cfg (or maybe pyproject.toml), or within tox.ini then?

I wish to limit the number of files and settings to the bare minimum. If it can fit into the tox.ini, it’s perfect.

How would the integration of flake8 looks like? This is very useful to improve overall code quality, on the other hand I don’t want the CI tests to fail because of styling issues.

1reaction

Delgancommented, Jan 20, 2019

I was a little worried that adding tox would clutter the repository needlessly and badly integrate with Travis, but thanks to tox-travis this is not the case. Using tox is best practice anyway, so there is no reason not to use it.

Thanks for the suggestion! A PR would be much appreciated when you have a little time, as you are surely more used to tox than I am. 🙂