Color codes not stripped from records with colorize=False

When adding a function sink with colorize=False the message attribute of the record does not have the color codes stripped. Here’s a short example showing the issue I mean:

from loguru import logger


def test_sink(message):
    assert "<red>" not in message  # This is fine
    assert "<red>" not in message.record["message"]  # This fails


logger.add(test_sink, colorize=False)
logger.opt(ansi=True).info("<red>something</>")

This is a problem for example when sending log records over the network, as in this recipe. https://loguru.readthedocs.io/en/stable/resources/recipes.html#sending-and-receiving-log-messages-across-network-or-processes

On the other side of the network, the record message still contains color codes, but we have no way of transmitting that the message should be processed with the .opt(ansi=True anymore. Perhaps rather than (or maybe in addition to) .opt() modifying the logger, the options should be attached to the log record?

[Delgan]

You’re right, it will not work well with multiple sinks on both server and client side. 😕

In any case, it doesn’t seem possible to correct this considering #197: both color tags and logging args are required as is during the formatting process (to handle coloring or stripping correctly), but it’s complicated for the client to propagate them separately to the server (meaning the message must not have been formatted).

I don’t think there is any proper solution I could implement. In my opinion, we have to accept the fact that color tags in the message cannot be transmitted through the network.

Here is another possible workaround, though: you could force colorize=True on the client side, and manually strip ansi codes in your sink (instead of relying on colorize) if needed in your server sinks (using ansistrip for example).

# server.py
from ansistrip import ansi_strip

logger.add(sink_supporting_colors)
logger.add(lambda m: sink_not_supporting_colors(ansi_strip(m)))

[Delgan]

Fixed in v0.4.1: the record["message"] will now always contain the stripped message.