Feature req: set FreeNAS comments field (org.freenas:description) to PVC name

I can see from the source there’s a few TODOs around setting zfs properties on volumes (https://github.com/democratic-csi/democratic-csi/blob/master/src/driver/controller-zfs-ssh/index.js#L349) and wanted to suggest another one. The previous freenas-iscsi-provisioner set the FreeNAS comments field on each managed share to the PVC name that was used to request it. This is quite useful as it allows at a glance in the FreeNAS UI to see a bit more detail about which k8s claim own a given volume (which is just called pvc-{uuid}).

I wonder how easy it would be for controller-zfs-ssh to get the PVC name and then add that property to the created dataset under org.freenas:description?

*edit: I wonder if the description on the iSCSI Extent could also be set similarly?

[travisghansen]

csi has no notion of pvc name or namespaces at all. I’m trying to remain co (container orchestrator) agnostic with the project and left it out (also partly because I simply didn’t have access to the data).

I did however discover recently that there is a flag you can set on one of the components which will send that info into the create volume call making it hypothetically viable.

[travisghansen]

Yeah, just add preview smb support if you need that for some crazy reason. I have no idea what I’m doing with smb so any testing/feedback would be great especially in a windows environment.