Question: how to customize the zfs/nfs generated dataset name to include namespace+ pvc name?

Q:

• is there a way to configure the name of the created zfs dataset name (and derived nfs share) to include the namespace/pvc related name?
• if so why. democratic-csi is installed via Helm

Currently the name of the zfs volume is"pvc-<pv uuid>" I know it is possible to change the static prefix “pvc-” by some static string I would like to have the dataset name to be "<namespace>-<pvc name>-<uuid>" (of course truncated to the max possible length)

Current config:

• Truenas v13.0-U3
• OpenShift v4.11 (k8s v1.24.6)
• democratic-csi image v1.7, csi-provisioner v3.1.0…

[travisghansen]

Yeah, iscsi has different limits for sizes etc (none of which are directly impacted by csi limits) making it less of an issue. In that case I use zfs props to store all that info as a quasi database, but I need to know the exact volume/dataset before I can get the props.

Regarding the volumeidfromname code, that works but the other methods which pass the id around don’t pass in the same parameters so I can’t deconstruct it 😦 the id must be the dataset name by my own convention (due to not having any kind of database).

I’m happy to leave this open. I would even be open to perhaps an entirely new ‘driver’ being introduced in the codebase which could meet your needs. I’m also open to introducing a soft delete to the existing drivers (although that normally would just be setting retain on storage class).

Also if it’s easier you can hit me up on slack/discord/whatever to have a more thorough discussion!

[titou10titou10]

Thanks for your answer

I naively thought that generating avolume_idbased onshorten(pvc_namespace+pvc_name+name)in theCreateVolume method executed when the volume is created would do the trick as this isvolume_idthat is received with the other lifecycle calls (egDeleteVolume) by the CSI engine after the volume is created. There is already adriver.getVolumeIdFromNamemethod that take care of generating a volume_id:

https://github.com/democratic-csi/democratic-csi/blob/7233bde497271c6a5bac13e757103313ef442359/src/driver/freenas/api.js#L2180

Also theiscsiimplementation do that via theiscsi.nameTemplateparameter that dynamically sets the name of the iSCSI extents/target/zvol in TrueNAS

iscsi:
    nameTemplate: "{{ parameters.[csi.storage.k8s.io/pvc/namespace] }}-{{ parameters.[csi.storage.k8s.io/pvc/name] }}

Anyway, thanks for your answer.

I’ll close soon this issue except if you want to keep it as a feature request…

I’m currently evaluating the possibility to create on my side a very specialized TrueNAS v13+/k8s v1.23+/Filesystem only/NFS CSI driver with this feature and some others from my current non-CSI provisionner: nfs-subdir-external-provisioner (like the possibility to ‘archive’ -ie rename instead of delete- the dataset when deleted)