Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor Pool

See original GitHub issue

To land #45 I had to disable Pool tests, rendering it unusable. Refactor has to be done to Pool, some initial thoughts:

rename PooledClient to PoolClient
Pool can be constructed from DSN
pool connection can be created lazily
size is optional default to 10
add Pool.transaction helper that wraps Pool.query in transaction

Issue Analytics

State:
Created 4 years ago
Comments:7 (2 by maintainers)

Top GitHub Comments

1reaction

mattbishopcommented, Apr 19, 2020

Ideally this lib would look like node-postgres as much as possible to aid transitions.

0reactions

haydcommented, May 23, 2020

Looking again, and rereading the issue, I don’t think the pool tests are disabled.

Top Results From Across the Web

Refactor Pool and Remote Replication | TrueNAS Community

I want to refactor each vdev from Z1 to Z2; A friend has plenty of spare capacity on his Z2 pool on a...

[Refactor] Go Worker Pool — A way around to the sync package

[Refactor] Go Worker Pool — A way around to the sync package. Synchronize worker executions by using Semaphore pattern instead of sync.WaitGroup ...

just C++ - pool refactoring - YouTube

Refactoring the pool class from last episode into a new template and a class which uses this new pool template.

Object Pool Design Pattern - SourceMaking

The general idea for the Connection Pool pattern is that if instances of a class can be reused, you avoid creating instances of...

perf: (pool): Refactor pool staking calls · pancakeswap/pancake ...

pancakes: Pancake main features (farms, pools, IFO, lottery, profiles) - perf: (pool): Refactor pool staking calls · pancakeswap/pancake-frontend@6400a7c.