Enforce at least one argument in commands

Variadic arguments are heavily used in the package. However, I think the way they are written now is quite error-prone. For example del https://github.com/denolib/deno-redis/blob/4ad600278d9c6aeccbbf624eb2593d895ebb9e1c/command.ts#L50 and most other commands require at least one argument. However, with the way the function is written above it’s easy to call del() without any arguments, and an error is thrown. It can be instead written like this, which is semantically similar but safer.

del(key: string, ...keys: string[]): Promise<Integer>;

Thoughts welcome!

[tumile]

Good point. Not being able to use spread is quite painful. The error being thrown was the reason I opened this issue, I thought we could leverage type checking to protect users from themselves. But seeing that it’s actually expected behavior in other packages, maybe we should follow the crowd here.

[uki00a]

PS) On second thought, I think the current behavior is not wrong 🤔

Reason 1: There may be a situation where users want to use an array

const keys = collectKeys();
await redis.del(...keys);

Reason 2: Some other clients behave the same way as this module

For example, go-redis, ioredis, and redis-cli gives the same error when no key passed:

go-redis

main.go

package main

import (
    "context"
    "fmt"
    "github.com/go-redis/redis/v8"  
)

var ctx = context.Background()

func main() {
    rdb := redis.NewClient(&redis.Options{
        Addr:     "localhost:6379",
        Password: "",
        DB:       0,
    })
    keysToDelete := []string{}
    n, err := rdb.Del(ctx, keysToDelete...).Result()
    if err != nil {
      fmt.Printf("%v\n", err)
    } else {
      fmt.Printf("%d\n", n)
    }
}

$ go run main.go
ERR wrong number of arguments for 'del' command

ioredis

index.js

const Redis = require("ioredis");
const redis = new Redis();
(async () => {
  try {
    await redis.del([]);
  } catch (err) {
    console.error(err);
  }
})();

$ node index.js
ReplyError: ERR wrong number of arguments for 'del' command
...