addr defaults to "0.0.0.0"

Describe the bug In server.ts, the function serve() unconditionally returns addr “0.0.0.0” This is incorrect for Windows and shows up in many Deno code examples and libs.

Expected behavior Should return “127.0.0.1” on Windows

OS: Windows 10

Additional context

deno_std/http/server.ts line# 265

export function _parseAddrFromStr(addr: string): HTTPOptions {
  let url: URL;
  try {
    //HACK add this line to return a correct default addr
    const defaultAddr = (Deno.build.os === "windows") ? "127.0.0.1" : "0.0.0.0";
    const host = addr.startsWith(":") ? `${defaultAddr}${addr}` : addr;
    url = new URL(`http://${host}`);
  }

[nhrones]

@kt3k I would agree that the problem is actually the logged messages in many downstream apps/libs. I’ve recently seen many of them corrected to log ‘http://localhost:xxxx’. Perhaps a lint to suggest localhost this would help. Since I opened this issue, should I close it here?

[treysis]

Keep in mind that on many systems, including Windows, localhost also resolves to ::1. Right now, I only know of Ubuntu that doesn’t resolve localhost to ::1, but instead uses ip6-localhost.