Discussion: asserts

In testing we originally had two methods assert and assertEqual

but at some point I (somewhat thoughtlessly) suggested that we mirror the Node API. So we have things like assert.equal as well as assertEqual.

What do people think? I kinda like assertEqual as it’s less to type and I imagine the tab completion is better in VS Code.

Obviously we should do one or the other but not both.

(Related: I’d really like to have https://github.com/bokuweb/deno-pretty-assert in core… cc @bokuweb)

[thysultan]

@keroxp Object.defineProperty can make the property non-writable/configurable but being able to monkey patch can be considered a plus in some cases.

There’s also the option of:

import * as assert from 'assert'

assert.equal(...)

[hayd]

#227 seems to be resolution of this discussion… ?