question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

suggestion: remove `_util/assert.ts`

See original GitHub issue

Please read #2846 before reading this. I suggest moving std/testing/asserts.ts to either an std/testing/asserts or std/asserts folder with an assertion-per-file. The folder would look more like std/fs.

Indeed, there is a large number of assertions, meaning there will be a large number of files. However, I think this is worth it to gain leaner assertion-related dependencies.

The files will have to be moved out, and then std/testing/asserts.ts functions deprecated. It’d be a bit of work, but I’d be happy to do it.

Issue Analytics

  • State:closed
  • Created 10 months ago
  • Comments:18 (18 by maintainers)

github_iconTop GitHub Comments

2reactions
cjihrigcommented, Nov 8, 2022

I agree with @kt3k

1reaction
kt3kcommented, Nov 8, 2022

We create an internal version of each assertion that uses DenoStdInternalError and put it in _util/asserts.ts.

I don’t think it’s worth it because we probably only need assert for internal assertions (and the usages are not so much increasing). Maybe let’s add others when they are needed.

We create a tool that enforces use of _util/asserts.ts using deno_graph.

I think this would be useful.

Read more comments on GitHub >

github_iconTop Results From Across the Web

When trying to import in deno, a lot of missing dependency ...
I'm open to suggestions to replace @pika/pack with our own build script that we use across all @octokit libraries. We have control over...
Read more >
mvn spring-boot: run throwing log4j errors - Stack Overflow
Either remove Logback or the competing implementation (class org.slf4j.impl. ... SimpleLoggerFactory at org.springframework.util.Assert.
Read more >
Syntax Error during deploy --build command step bundling ...
Hi, i am experiencing an issue using netlify-cli to build and deploy a site with some netlify functions. Locally using netlify dev command ......
Read more >
The ultimate beginner's guide to Deno | The JS runtimes
As Deno comes as a single executable, the uninstallation procedure is all about removing that executable. This needs to be done manually (at...
Read more >
spring-projects/spring-security - Gitter
I have a problem about sending any request to a defined service through api gateway with the usage of bearer token coming from...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found