question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

formatter runs when deno.enable = false

See original GitHub issue

Describe the bug

When deno.enable is set to false saving a javascript file still hangs trying to run the Deno formatter.

To Reproduce

  1. Install Deno extension
  2. Enable extension in VS Code
  3. Set "deno.enable": false in User Settings
  4. Make a change to a .js file
  5. Save the file

Expected behavior

The file should save without any attempt to run the deno formatter

Screenshots

image

Versions

Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 19.6.0

deno 1.3.3 v8 8.6.334 typescript 4.0.2 extension: 2.2.0

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:23 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
CGQAQcommented, Sep 9, 2020

The key capture feature is vsode-built in feature capture app is LICEcap

0reactions
CGQAQcommented, Sep 9, 2020

I’m still confused though, because if I comment those lines out entirely I still get deno trying to run as the formatter. What is causing it to be selected when no formatter is defined?

that’s vscode’s problem, you should definitely open an issue on vscode repo. I don’t have permission to close the issue, please close it, thank you

cc @lucacasonato close this issue

Read more comments on GitHub >

github_iconTop Results From Across the Web

Using Visual Studio Code | Manual - Deno
In the panel the setting is Deno: Enable and when manually editing the JSON, ... See the Code formatter for more information on...
Read more >
How do I get format on save to work with Deno? - Stack Overflow
In order to get the behavior that you want, you need to configure the following settings: "editor. formatOnSave" : Set to true (This...
Read more >
Deno - Visual Studio Marketplace
The formatter will respect the settings in your Deno configuration file, which can be explicitly set via deno. config or automatically detected ...
Read more >
Deno 1.29: Custom npm registry support
Starting with this release, all built-in Deno tooling will skip node_modules/ and .git/ directories by default. You can run tools like formatter ......
Read more >
Deno - Nova Extensions - Panic Inc.
A complete development toolchain including a formatter, linter, test runner, bundler, and language ... Task templates for deno run and deno bundle commands....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found