denon [script name] doesn't kill app on reload

I have a simple web server application running with oak. When I use the command denon run --allow-net app.ts the auto reload successfully kill the webserver on each reload.

But when I use the denon dev command and using the denon.json file, the application isn’t killed on each reload. For example, if I run the webserver on 8080 port, then change it to 8081 then save, I end up with 2 webserver. If I doesn’t change the port between two save, I hand up with an error saying one app already use this port.

Here is my denon.json file

And my app.ts file

[dale-roberts]

I have also confirmed this to still be a problem, using Windows 10, Deno 1.6.3, and Denon 2.4.5. I believe the problem is that when the killAll() routine in deamon.ts calls p.close() under Windows, this is not actually killing the process. Can confirm this with ProcessExplorer, and see that the original process ID is never killed, and subsequent processes die due to the Socket reuse error.

I’m not a Github guru, so I’m just posting my small change here, adding p.kill() to the Windows case, which fixes the problem for me.

if (Deno.build.os === "windows") {
     logger.debug(`closing (windows) process with pid ${p.pid}`);
     p.close(); // This original line does NOT end the process.
     p.kill(9); // <<<<<< This added line DOES end the Windows process.
} else {
     logger.debug(`killing (unix) process with pid ${p.pid}`);
     p.kill(9);
}

Could also just get rid of the whole “if” and use kill() always. But I’m sure p.close() was added specially for Windows for some reason, and based on other reports here it seems to sometimes work, so I’m not sure why it is not working for all of us. I’m also not sure whether kill() has any bad/unintended effects in Windows.

[MustachedNinja]

Thanks @dale-roberts , I submitted a pull request for your suggestion: #120