False positivies on app-module-path

While using app-module-path, every required module affected by that is reported as a “missing dependency”.

Missing dependencies
* logger
* config
* services
* lodash

Here, logger and config are actually located under an ./app directory, but the relative path can be omitted thanks to:

require('app-module-path').addPath(__dirname + '/app');

being present at the beginning of the main script. Moreover, services is not even a module. The actual requirements comes from:

const seneca = require('services/seneca');

Can’t say why depcheck reports it that way.

[mrchief]

This package does something really bad - it changes the node.js built-in behavior.

I agree with @lijunle on this one. The extra dots are simple and intuitive. app-module-path not only alter default behaviors and thus breaking any tool chain that rely on default behavior, but it also open up the possibility of abuse and violates the principle of least surprise.

I’d actually vote for not supporting it. If possible, make the support for non-standard things available via plugins. People can opt-in if they choose to do so.

[ericelliott]

FYI, it’s reporting false positives for modules in NODE_PATH, too.