TSLint

Hey,

I’m adding support for TSLint, and it turns out that the code is basically exactly the same as for ESLint.

--- src/special/eslint.js	2018-08-09 13:33:55.000000000 +0100
+++ src/special/tslint.js	2018-08-09 13:45:28.000000000 +0100
@@ -101,10 +101,10 @@
 
 function checkConfig(config, rootDir) {
   const parser = wrapToArray(config.parser);
-  const plugins = wrapToArray(config.plugins).map(plugin => `eslint-plugin-${plugin}`);
+  const plugins = wrapToArray(config.plugins).map(plugin => `tslint-plugin-${plugin}`);
 
   const presets = wrapToArray(config.extends)
-    .filter(preset => preset !== 'eslint:recommended')
+    .filter(preset => preset !== 'tslint:recommended')
     .map(preset => resolvePresetPackage(preset, rootDir));
 
   const presetPackages = presets
@@ -120,9 +120,9 @@
   return lodash.union(parser, plugins, presetPackages, presetDeps);
 }
 
-export default function parseESLint(content, filename, deps, rootDir) {
+export default function parseTSLint(content, filename, deps, rootDir) {
   const basename = path.basename(filename);
-  if (/^\.eslintrc(\.json|\.js|\.yml|\.yaml)?$/.test(basename)) {
+  if (/^\.tslintrc(\.json|\.js|\.yml|\.yaml)?$/.test(basename)) {
     const config = parse(content);
     return checkConfig(config, rootDir);
   }

How would you prefer this to be done?

1. Keep as two files with basically the same content
2. Extract the code out to e.g. src/util/linters.js and just have a basic call in specials/*.js
3. Just have eslint also check for tslint files/packages

Cheers 🍻

[rumpl]

Go for option 2 then, less code we have the better 😃

[mnkhouri]

Fixed in #266, #270 😃