Does not get correct dependencies when mixing es6 and cjs import syntax

I’m working on a rather large code base that is slowly transitioning from es5 to es6. There are a lot of files that have mixed imports: i.e. both require() statements and import statements. node-precinct does not correctly extract all the dependencies.

For example, given the file:

require('./foo');
import './bar';

only the foo dependency will be recognized.

If you flip it around, and have a file like:

import './bar';
require('./foo');

only the bar dependency will be recognized.

So in otherwords, precinct use looks at the first syntax it encounters and uses that for the rest of the file, even though the file may have a mix of cjs and es6.

[mrjoelkemp]

@pcardune I added an option es6.mixedImports that will chain the es6 and cjs detectives. See the usage docs for the syntax.

You can get this with a fresh install of madge, but I’ll still bump precinct within dependency-tree.

Thanks again for suggesting the feature. Let me know if you run into any issues.

[mrjoelkemp]

Fair point @pcardune! The goal of precinct is zero configuration, but i like the opt-in perf regression for transitionary codebases. Will work on that and support the option all the way up to madge.