aria-hidden-focus does not account for inputs being inside a disabled <fieldset>

Product: axe Extension

Expectation: An input that is inside a <fieldset> that has been disabled should not be treated as focusable by the aria-hidden-focus rule

Actual: An input that is inside a <fieldset> that has been disabled is still treated as focusable by the aria-hidden-focus rule

Motivation: The aria-hidden-focus rule returns a false positive when aria-hidden is used with a disabled fieldset

Example: The aria-hidden-focus rule flags the following as a serious issue, despite the input not actually being focusable.

<fieldset disabled="disabled" aria-hidden="true">
	<input />
</fieldset>

axe-core version: 4.2.0
axe extension version: 4.9.3

[straker]

Nope. Closing was intended. The issue has been resolved and should be available in the latest release.

[WilcoFiers]

Thank you for reporting the issue. We’ll be sure to fix it. I think the problem is in dom.focusDisabled, which do https://github.com/dequelabs/axe-core/blob/develop/lib/commons/dom/focus-disabled.js#L10

To fix this we’ll need to have i check walk up the tree to see if there’s a disabled fieldset. Should be fairly straightforward. The one thing to be mindful of in fixing this is to check how this interacts with shadow DOM. I recall that disable only works on descendants in the same DOM tree. We should test it to make sure.