Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Breaking change between 3.5.1 and 3.4.2
See original GitHub issueA breaking change seems to have slipped in between axe-core 3.5.1 and 3.4.2.
eslint-plugin-jsx-a11y uses axe-core in tests.
Tests in eslint-plugin-jsx-a11y were failing for me with axe-core 3.5.1 installed. After ‘fixing’ the tests, they were passing locally but now failed in CI. I manually downgraded a few times and did some digging and found this commit which looks like it’s the cause of the failing tests.
Expectation: no breaking changes between patch and minor version bumps.
Actual: a breaking change was introduced between two patch version bumps.
axe-core version: 3.4.2, 3.5.1
For Tooling issues:
- Node version: several
- Platform: Travis CI
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:11 (7 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@ljharb You are absolutely right. Axe-core was built in a time where concatenation was the standard, and denoting private was done by starting prop names with underscore. We are working to change this, make things properly encapsulated. We’ll add an API specifically for generating messages, so we don’t have to do this kind of stuff.
You know, I just noticed that @WilcoFiers added that file, and so I guess we just shot ourselves in the foot… Due to that I think we might have to considered this a breaking change, but I’m not sure we can revert it back to the former API style. I think our best course of action may be to create a new public API that can be used to access check messages.