Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Performance of dom.findUp is very slow
See original GitHub issueAs you know, the performance of dom.findUp is really poor. However it is used very heavily across the various rules/checks.
AFAICT, you could use the DOM API of element.matches() which should be substantially faster. (browser support is good).
You basically have written the polyfill for it, so you can fall back to your current implementation if ('matches' in element) is false.
Good site to reproduce on: https://www.mlb.com/ Screenshot of the color-contrast rule taking 26s to complete. (All of the time is spent in the querySelectorAll within findUp)
Issue Analytics
- State:
- Created 6 years ago
- Comments:19 (13 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
This is a fantastic improvement. It gets the time for the mlb.com home page down to around 14s from 28s - that is an improvement of 50% overall…thanks for the help @paulirish @patrickhulce and @kdzwinel
I just tested and on https://www.mlb.com/yankees/schedule/2018-03` axe runtime is down from 60s+ (LH has a 60s timeout for gatherers) to 29s 🎉