Not working with only srcset

Hi there

I have a scenario where I have to use only srcset for images. The problem is, in this way it does not wait for the images to load and run the callback function. I did change the following line from the . js file as follows:

`// original code from js file this.proxyImage.src = this.img.src;

// I changed it as for srcset workout this.proxyImage.src = this.img.srcset;`

In this way it works like I want but it is making the double request for each image and throwing the error for 2nd img request.

How this can be fixed.

Regards, Shehzad Asif

[ashehzadgec]

Thanks for the reply, I’ll check it (will take some time as now working of some project). If not worked in my situation, will get back to you.

On Sat, Jul 10, 2021 at 4:25 AM trevDev(); @.***> wrote:

Here’s a set of functions I wrote to handle this myself. If anyone else might benefit from this go ahead:

function determineImageSource(elm) { if (elm.src) return elm.src; if (elm.currentSrc) return elm.currentSrc; if (elm.style.backgroundImage) { const pattern = /\burl\s*(\s*[“']?([^”‘\r\n)(]+)["’]?\s*)/ match = elm.style.backgroundImage.match(pattern); try { return match[1] } catch { return null } } return null; }

function isImageLoaded(elm) { return new Promise(function(resolve, reject) { var src = determineImageSource(elm); if (src === null) return resolve(); var img = new Image();

    img.onload = function() {
      resolve(img);
    };
    img.onerror = function() {
      resolve(img);
    };
    img.src = src;
})

}

function afterImagesLoad(parent, callback) { var container = document.querySelector(parent); if (container === null) throw Error(‘No parent for allImagesLoaded’);

var imgElms = Array.from(container.querySelectorAll('img'));
var bgImages = Array.from(
  container.querySelectorAll('[style*="background-image"]')
);

var imgs = imgElms.concat(bgImages);
var promises = imgs.map(isImageLoaded);

Promise.all(promises).then(callback)

}

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/desandro/imagesloaded/issues/299#issuecomment-877507041, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQYRBXS4VSB7JHCKYTIHW3TW6AQLANCNFSM44ZPVL6A .

[ashehzadgec]

Thanks for listening to us.

On Mon, Feb 21, 2022 at 10:53 PM David DeSandro @.***> wrote:

imagesLoaded v5 has been released with better support for srcset. Please upgrade and report back if you still run into issues.

— Reply to this email directly, view it on GitHub https://github.com/desandro/imagesloaded/issues/299#issuecomment-1047115983, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQYRBR7WCZXNCBJFVKWZ6TU4J3ZPANCNFSM44ZPVL6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>