After pushing a branch and creating a PR, GitHub desktop still thinks, I can create a pull request.
See original GitHub issueDescribe the bug
After pushing a branch and creating a PR, GitHub desktop still thinks, I can create a pull request and doesn’t display the current PR state.
Version & OS
Version 2.3.1 macOS 10.15.3
Steps to reproduce the behavior
- Create a branch from master
- Commit a change
- publish the branch
- create a pull request
Expected behavior
After the creation of the pull request, GitHub desktop should track the PR state. And it should say something “No local changes, push further commits to the PR.”
Actual behavior
GitHub desktop remains in the state, that the branch has been pushed, but no PR has been created. It doesn’t track the PR.
Logs
That’s a clip of the log:
2020-02-10T12:57:27.628Z - info: [ui] Executing getStatus: git --no-optional-locks status --untracked-files=all --branch --porcelain=2 -z (took 1.841s)
2020-02-10T12:57:27.885Z - info: [ui] Current tutorial step is NotApplicable
2020-02-10T12:57:27.898Z - info: [ui] skipping fast-forward for all branches as there are 20 eligible branches (Threshold is 20 eligible branches).
2020-02-10T13:04:56.811Z - info: [ui] Executing getStatus: git --no-optional-locks status --untracked-files=all --branch --porcelain=2 -z (took 1.364s)
2020-02-10T13:08:39.459Z - info: [ui] Current tutorial step is NotApplicable
2020-02-10T13:09:05.838Z - info: [ui] Current tutorial step is NotApplicable
2020-02-10T13:09:06.782Z - info: [ui] [Timing] Action 'create commit' for 'musicapps/MusicApps' took 3.027s
2020-02-10T13:09:12.653Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: MusicApps - sdiedric (has token)
2020-02-10T13:09:19.324Z - info: [ui] Executing push: git -c credential.helper= push origin Issue-#509-CGenData.cpp-CFPropertyListCreateFromXMLData-deprecated --set-upstream --progress (took 6.670s)
2020-02-10T13:09:23.370Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 4.044s)
2020-02-10T13:09:23.943Z - info: [ui] [fetchPushControl] unable to check if branch is potentially pushable
Error: Branch not found
at Object.t.parsedResponse (/webpack:/app/src/lib/http.ts:175:4)
at x.fetchPushControl (/webpack:/app/src/lib/api.ts:826:14)
at Ve.refreshBranchProtectionState (/webpack:/app/src/lib/stores/app-store.ts:883:29)
at m.performFailableOperation.retryAction (/webpack:/app/src/lib/stores/app-store.ts:3536:13)
at x.performFailableOperation (/webpack:/app/src/lib/stores/git-store.ts:733:22)
at /webpack:/app/src/lib/stores/app-store.ts:3493:9
at Ve.withPushPullFetch (/webpack:/app/src/lib/stores/app-store.ts:3609:7)
2020-02-10T13:09:24.927Z - info: [ui] Current tutorial step is NotApplicable
2020-02-10T13:09:24.936Z - info: [ui] skipping fast-forward for all branches as there are 20 eligible branches (Threshold is 20 eligible branches).
2020-02-10T13:09:27.746Z - info: [main] opening in browser: https://github.aso.apple.com/MusicApps/MusicApps/pull/new/Issue-%23509-CGenData.cpp-CFPropertyListCreateFromXMLData-deprecated
2020-02-10T13:10:32.610Z - info: [ui] Current tutorial step is NotApplicable
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (3 by maintainers)
Top Results From Across the Web
Creating a pull request - GitHub Docs
Create a pull request to propose and collaborate on changes to a repository. These changes are proposed in a branch, which ensures that...
Read more >Creating an issue or pull request - GitHub Docs
After you create a branch and make changes to files in a project, you can create a pull request. With a pull request,...
Read more >Create Pull Request button showing when there is an existing ...
Open GitHub Desktop; Open a repository; Switch to a non-base branch or create a new one; Make a change in the code; Commit...
Read more >The menu item Branch -> Create Pull Request is disabled ...
When I open the GitHup repo in the browser -> "Your recently pushed branches" I can hit "Compare & Pull Request", it works...
Read more >Pull Requests not showing with new Branches after fetching
After creating a new branch and PR on dotcom, and then fetching the changes in Desktop, only the new branch showed up. Desktop...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I am still experiencing this issue - macOS 10.15.7, Github Desktop 2.5.6, working with a private Github repository. The PR tab in the branches dropdown does not update with the currently open PRs in the repository. I have to manually find the branch of the PR in the branches tab and switch to it.
Thank you for your issue! We haven’t gotten a response to our questions above. With only the information that is currently in the issue, we don’t have enough information to take action. We’re going to close this but don’t hesitate to reach out if you have or find the answers we need. If you answer our questions above, a maintainer will reopen this issue.