Any commits during Publishing/Pushing get pushed too

So if you make a commit while another commit is being published to dotcom or Enterprise, that second commit is pushed up along with the first one. When the user clicks the Publish button, the number badge is displayed with the amount of commits to be pushed, however, the user might be unaware that if they make a commit during the publishing process, that it would be immediately pushed, too.

Perhaps we could temporarily disable the commit button until the publishing process has reached a certain point?

v0.6.1, OSX 10.11.5

Reproduce (Pushing):

• For a currently published repo, add multiple changed files to the queue
• Commit one so the published badge number increments
• Now prep another file for commit without hitting the Commit to X button
• Click the Publish button and immediately after click the Commit button
• Both changes are pushed up to the repo

Expected behavior: the second commit would be separate from the first, prompting the user to publish them separately. On Step 4 above, if the user waits a second or two, the expected behavior holds true.

[shiftkey]

@tierninho can we update this issue to differentiate between the publish flow (the publish dialog which takes a repository without any remotes and puts it on GitHub) and push (the repository has a remote, and a long-running operation like pushing new commits you could do other work)? You mention that this repository is published, which should mean the button is for pushing.

[mido1966]

Thank you very one es ok Dankeschön alles ok

‏‫من الـ iPhone الخاص بي‬

‫في 18‏/03‏/2019 الساعة 10:30 م، كتب/كتبت ‏Tiernan L ‏<[e-mail]:[e-mail]>:‬

Closed #2005https://github.com/desktop/desktop/issues/2005.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/desktop/desktop/issues/2005#event-2211805118, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsxK37yGr00JgriyaEvAiDXNkBnzbVpEks5vYAVggaJpZM4N6ODL.