authentication fails for https://{username}@github.com remote

Description

Can not access my private GitHub repository as the remote syntax isn’t handled by the application.

Version

GitHub Desktop version: 0.5.8 OS version: macOS 10.12.5

Steps to Reproduce

1. Open Local Repository (private GitHub repository)
2. Trying to Push
3. Error: Athentication failed.
4. Logging out and in again.
5. Trying to Push
6. Error: Athentication failed.

Expected behaviour: Pushing commit Actual behaviour: Authentication fails Reproduces how often: 100%

Logs

2017-05-29T09:25:29.011Z - info: Opt in reported.
2017-05-29T09:25:29.565Z - info: Stats reported.

Additional Information

This issue does not appear with the current (stable) GitHub Desktop client.

[shiftkey]

Cool, that sounds like we’re on the right track.

Do HTTPS remotes work with two-factor auth?

@EisenbergEffect we handle the 2FA flow when you sign into your GitHub account in the app, and the authorization token we use then is stored locally for use with your Git operations. So if you switch it over to a HTTPS remote we’ll pass that token through to the Git operations.

git remote set-url origin https://github.com/aurelia/logging.git

[shiftkey]

@EisenbergEffect yeah, if you run this command from the terminal in the repository you should see the remote URL:

git remote -vv

We haven’t gotten around to proper support for SSH remotes (see #1795 for example) and I wanted to confirm that you’re using a HTTPS remote (which we do default to if you’ve cloned the repository in Desktop)