question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Automatics checks for update in 0.8.0 do not work, manual update check fails

See original GitHub issue

Description

In regular use of GitHub desktop 0.8.0 it was never found out that new versions of the program have appeared. Manual update checks have made the spinner running for forever, and, at another time, generated “Error: command failed” in the code about the IO on the downloaded “delta” file for 0.8.1 version (see below).

Version

0.8.0

Steps to Reproduce

See above.

Logs

2017-09-13T11:48:48.949Z - error: [ui] Error checking for updates
Error: Command failed: 4294967295
System.AggregateException: ��������� ���� ��� ��������� ������. ---> System.Net.WebException: ���������� �� ����� ������� WebClient. ---> System.IO.IOException: ������� �� ����� �������� ������ � ����� "C:\Users\������������\AppData\Local\GitHubDesktop\packages\GitHubDesktop-0.8.1-delta.nupkg", ��� ��� ���� ���� ������������ ������ ���������.
   � System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   � System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   � System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access)
   � System.Net.WebClient.DownloadFileAsync(Uri address, String fileName, Object userToken)
   --- ����� ����������� ����������� ����� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.Utility.<LogIfThrows>d__37.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.FileDownloader.<DownloadFile>d__2.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.UpdateManager.DownloadReleasesImpl.<>c__DisplayClass2_0.<<DownloadReleases>b__1>d.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.Utility.<>c__DisplayClass13_0`1.<<ForEachAsync>b__1>d.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.UpdateManager.DownloadReleasesImpl.<DownloadReleases>d__2.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.UpdateManager.<DownloadReleases>d__8.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.Update.Program.<Download>d__7.MoveNext()
   --- ����� ����������� ����������� ����� ���������� ---
   � System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   � System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   � System.Threading.Tasks.Task`1.get_Result()
   � Squirrel.Update.Program.executeCommandLine(String[] args)
   � Squirrel.Update.Program.main(String[] args)
   � Squirrel.Update.Program.Main(String[] args)
---> (���������� ���������� #0) System.Net.WebException: ���������� �� ����� ������� WebClient. ---> System.IO.IOException: ������� �� ����� �������� ������ � ����� "C:\Users\������������\AppData\Local\GitHubDesktop\packages\GitHubDesktop-0.8.1-delta.nupkg", ��� ��� ���� ���� ������������ ������ ���������.
   � System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   � System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   � System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access)
   � System.Net.WebClient.DownloadFileAsync(Uri address, String fileName, Object userToken)
   --- ����� ����������� ����������� ����� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.Utility.<LogIfThrows>d__37.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.FileDownloader.<DownloadFile>d__2.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.UpdateManager.DownloadReleasesImpl.<>c__DisplayClass2_0.<<DownloadReleases>b__1>d.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.Utility.<>c__DisplayClass13_0`1.<<ForEachAsync>b__1>d.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.UpdateManager.DownloadReleasesImpl.<DownloadReleases>d__2.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.UpdateManager.<DownloadReleases>d__8.MoveNext()
--- ����� ����������� ����� �� ����������� ������������, ��� �������� ���������� ---
   � System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   � System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   � Squirrel.Update.Program.<Download>d__7.MoveNext()<---


    at AutoUpdater.emitError (C:\Users\[UserName]\AppData\Local\GitHubDesktop\app-0.8.0\resources\electron.asar\browser\api\auto-updater\auto-updater-win.js:58:24)
    at squirrelUpdate.download (C:\Users\[UserName]\AppData\Local\GitHubDesktop\app-0.8.0\resources\electron.asar\browser\api\auto-updater\auto-updater-win.js:34:21)
    at C:\Users\[UserName]\AppData\Local\GitHubDesktop\app-0.8.0\resources\electron.asar\browser\api\auto-updater\squirrel-update-win.js:89:14
    at ChildProcess.<anonymous> (C:\Users\[UserName]\AppData\Local\GitHubDesktop\app-0.8.0\resources\electron.asar\browser\api\auto-updater\squirrel-update-win.js:71:14)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

Additional Information

This might be related with the issue of code pages and their conversions?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:12 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
shiftkeycommented, Sep 14, 2017

Well I think I know the problem.

The 0.8.0 client will send this information to the update server:

https://central.github.com/api/deployments/desktop/desktop/latest/RELEASES?version=0.8.0&env=production&id=GitHubDesktop&localVersion=0.8.0&arch=amd64

The response that comes back contains these versions:

1E607824B9FBFF5BE34EF5F393464AE899F6EFBD GitHubDesktop-0.8.0-full.nupkg 81440726
9089B32450BDFE613B7A9166C48E302AD68A161A GitHubDesktop-0.8.0-delta.nupkg 7628586
D54413BEFA17FEEB07961CBCE84DCB3723A46BED GitHubDesktop-0.8.1-full.nupkg 83060889
9030AF1B22A26478313C47340903F035243C9058 GitHubDesktop-0.8.1-delta.nupkg 25349535
927552E29DB302DC8B87BE98B676D46516749826 GitHubDesktop-0.8.1-full.nupkg 83070985
A269767E5A34BF238B0D5AE9F4514F70899AB9D5 GitHubDesktop-0.8.1-delta.nupkg 25359887
B613F69D0627613790286E01850249532ACFCE2C GitHubDesktop-0.8.2-full.nupkg 83068989
92975B6F11F0A921C475E25F5B41A0A507E308F7 GitHubDesktop-0.8.2-delta.nupkg 732885

And in the SquirrelSetup.log file there’s these three messages:

2017-09-14 11:36:38> FileDownloader: Downloading file: https://central.github.com/api/deployments/desktop/desktop/latest/GitHubDesktop-0.8.1-delta.nupkg
2017-09-14 11:36:38> FileDownloader: Downloading file: https://central.github.com/api/deployments/desktop/desktop/latest/GitHubDesktop-0.8.1-delta.nupkg
2017-09-14 11:36:38> FileDownloader: Downloading file: https://central.github.com/api/deployments/desktop/desktop/latest/GitHubDesktop-0.8.2-delta.nupkg

This explains the file being locked - it’s trying to download the same file twice.

I’ll look at our update server code and see if we can get it to return just one delta update for the 0.8.1 release, which should unblock clients that are stuck and unable to update, without needing to reinstall.

0reactions
joshabercommented, Sep 15, 2017

Great! Sounds like this is fixed 🤘

Read more comments on GitHub >

github_iconTop Results From Across the Web

Cannot auto-update apps and/or check for app updates
The problem is with checking for updates, not downloading them. Installing and updating apps does work manually, if I go to an app's...
Read more >
Troubleshooting a Check for Updates Failed Error
Begin by navigating to Utilities > Update WHMCS. ... The following warning will appear: Warning You do not currently have a path configured...
Read more >
How to fix the Update Failed error message ... - Mozilla Support
This article presents solutions and workarounds to a failed Firefox update so that you can get it updated and working correctly again.
Read more >
Troubleshooting Automatic Updates - Ableton
1. Make sure Automatic Updates are enabled · 2. Make sure that you have an active internet connection · 3. Wait until the...
Read more >
K15000: Overview of the Automatic Update Check ... - AskF5
Log in to the Configuration utility. · Go to System > Software Management > Update Check. The list of available software updates is...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found