Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Block emoji from being entered as a repo name

See original GitHub issue

Emoji shouldn’t be allowed in place of a repo name as they are converted anyway to “normal” characters by GitHub.com and Desktop once published.

If you already have a repo with the namegithub.com/tierninho/-1 and you decide to create a new repo with an emoji 🐴 as the repo name, the name becomes converted to “normal” characters as expected. However, if you click “open in GitHub” or “create PR”, the existing repo is opened despite the real url being github.com/tierninho/-

Just remove the Emoji option from the Edit menu?

tested 1.0.5beta0, mac

Issue Analytics

State:
Created 6 years ago
Comments:10 (7 by maintainers)

Top GitHub Comments

1reaction

Daniel-McCarthycommented, Oct 22, 2018

@outofambit Sounds great! I have the changes ready and will get a pull request ready soon.

I think its best to preserve that behavior for now.

I certainly agree. I was hoping that perhaps this might be an opportunity for some improved documentation to explain this, so I gave it a mention while it was relevant.

1reaction

outofambitcommented, Oct 22, 2018

@Daniel-McCarthy that seems like a sensible approach to me. I’m not sure about the reasoning for filtering out _ so I think its best to preserve that behavior for now. thank you!