Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Branch list (compare tab) hides after specific pattern of keyboard events

See original GitHub issue

Description

Stumbled upon this while testing keyboard navigation for #5368

Version

GitHub Desktop: 1.3.2-beta
Operating system: macOS

Steps to Reproduce

Open the compare tab, and focus on the filter textbox
Press Down to select first branch
Press Up to select filter textbox
Press Down to select first branch again

Expected Behavior

Branch list is visible and first branch is selected, ready to confirm

Actual Behavior

Branch list is hidden

Additional Information

Here’s a GIF:

branch-selector-hides

I’m also not sure why the list “jumps” a bit after keying down to focus on the first branch.

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

shiftkeycommented, May 30, 2019

@ADustyOldMuffin I’m not sure.

It’s been a while since I opened this, but I’ll re-test this tomorrow and see what work needs to be done in here.

0reactions

shiftkeycommented, Jun 14, 2019

I’ve opened #7802 to indicate what the current behaviour is and what should occur, rather than continue to work with this stale issue.

Top Results From Across the Web

Telescope.nvim - GitHub

telescope.nvim is a highly extendable fuzzy finder over lists. Built on the latest awesome features from neovim core. Telescope is centered around ...

Searching - Notepad++ User Manual

Find in Files tab: Allows you to search and replace in multiple files with one action. The files used for the operation are...

git-log Documentation - Git

List commits that are reachable by following the parent links from the given commit(s), but exclude commits that are reachable from the one(s)...

Changes in merge requests - GitLab Docs

A merge request proposes a set of changes to files in a branch in your repository. These changes are shown as a diff...

KeyboardEvent - Web APIs | MDN

The following constants identify which part of the keyboard the key event originates from. They are accessed as KeyboardEvent.