'Delete Branch' warns that branch already exists on remote after it's deleted

Description

When I click on Branch > Delete…, I get a popup dialogue saying “The branch also exists on the remote, do you wish to delete it there as well?”. This is a useful message, but it always seems to say that, even after I have deleted the branch in GitHub after I merge. I have also tried switching to master and Fetching Origin first and trying again, but I am still getting the same message.

Version

GitHub Desktop version: 1.0.3

OS version: 10.12.6

Steps to Reproduce

1. Create branch in GitHub Desktop
2. Publish branch to GitHub
3. Delete branch in GitHub
4. Click to delete branch in Github Desktop

Expected behavior: I expected the branch to be deleted on the remote and thus not be notified otherwise.

Actual behavior: I was informed that the branch still exists on the remote, even after having deleted the branch.

Reproduces how often: 100%

Logs

2017-10-04.desktop.production.log

Additional Information

[JordanMussi]

Fixed in #3469 😃

[shiftkey]

So this is the work to check if the branch exists on the remote:

https://github.com/desktop/desktop/blob/c23b1ae24cd82233e4b0cb3503f8fc621cb370d5/app/src/lib/git/branch.ts#L88-L100

If someone wants to pick this up, they could look to making that reusable, so we can check when displaying the form whether the remote exists. That would bypass the need to do a fetch, but still incurs the network penalty.