Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Desktop not compiling if directory path contains a space

See original GitHub issue

Describe the bug

If path of Desktop repo contains a space, then Desktop is not compiled, returning an error.

Version & OS

Github Desktop: development branch, OS: Windows 10

Steps to reproduce the behavior

Compile Desktop with yarn build:dev

Expected behavior

Compiling without error.

Actual behavior

Generates an error (image below) during compile.

Screenshots

Cattura

Additional context

If path doesn’t contain spaces (in my case) it compiles correctly. If the error isn’t repairable, I suggest to add a note in “docs/contributing/setup.md”. Or add the same note into troubleshooting section.

Issue Analytics

State:
Created 3 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

ruggi99commented, May 22, 2020

@rafeca how about opening a PR to update only the cross-zip dependency and close this issue? I know it’s not the best practice to edit manually the yarn.lock file, but I think it won’t break anything.

0reactions

rafecacommented, May 25, 2020

Sounds good to me as a temporary fix, so feel free to send the PR!

Note that electron-packager is moving away from cross-zip to extract-zip (see https://github.com/electron/electron-packager/pull/1139), but either way upgrading cross-zip to v3.1.0 should be fine now.