Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Dialog "close" button has wrong name and label for screenreaders
See original GitHub issue
Screenreaders announce the close button as a link with no name.
This should be resolved by setting name="close" and role="button" in the a tag below.
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (7 by maintainers)
Top Results From Across the Web
ARIA: dialog role - Accessibility - MDN Web Docs - Mozilla
When the dialog is correctly labeled and focus is moved to an element (often an interactive element, such as a button) inside the...
Read more >Using ARIA role=dialog to implement a modal dialog box
all page elements except the content of the modal custom dialog) by setting its aria-hidden attribute to true once the dialog is displayed...
Read more >[Accessibility] Dialog cancel button missing aria-label #1863
Describe the issue: The name of the cancel button at top of dialog in the "Inspect" tool is missing. Actual behavior: Open the...
Read more >Screen Reader message for closing modal - Stack Overflow
When the event handler is triggered, close the modal, then post a message to the aria-live region stating that the modal has closed, ......
Read more >The dialog element: Part 2 of 2 - John Sweet's Accessibility Blog
Be sure to label this button with aria-label="Close dialog" . The extra wording “dialog” is helpful, since in some screen reader browser ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Hi @outofambit! I use Github Desktop for most of my git needs and as an avid user I am excited to start contributing to some of the issues on here. Since this issue was marked as a
good first issueI figured this might be a good place to start so I’d love to work on it!I am currently following the instructions on this setup guide and will start working on the actual issue part soon after getting set up.
I’d like to first take a swing at finding the right place(s) in the codebase to make this change you suggest, but if I’m unable to find it I’ll be sure to message this board so that you can point me in the right direction! 😃
PS: I had the pleasure of meeting you at Github’s Constellation event in Los Angeles in April 2018, where I thoroughly enjoyed your presentation about welcoming contributors to an OSS project. I was the UCLA CS student who had come up to speak with you later about my ideas in that regard. I’m excited to work on this and hopefully some more Github Desktop issues with you!
Hi @HirdayGupta! Thanks for joining us here! I do remember you from GitHub Constellation LA and its so nice to hear from you again! 💖 Please feel free to
@me whenever for questions or anything!I’m excited to have you working with us on GitHub Desktop! Let me know if you have any questions about setting up the repo for development! 🤠