Difficult to visually determine which line is selected in Windows context menu on discard changes

Description

I am in a repo with several local commits that involved a file. That file turns out never needed to be changed. Right click that file in the GitHub Desktop explorer -> Discard changes. This removed ALL of my changes even though I didn’t click Discard All Changes.

Oh that’s alright they are just in your Recycle bin.

My Recycle bin is currently too big. and after just 5 minutes after opening is STILL not fully indexed.

I made MULTIPLE undone changes to my files. I see the folder I changed, double click and I only get properties? I can only “Restore folder” from here? So if I discard multiple changes only the last discarded change to a file will be around? So would discarding different files at different times restore only the last discarded change of that file?

Version

• GitHub Desktop: 1.4.3

• Operating system: Windows 10 1809 (OS Build 17763.55)

Steps to Reproduce

1. This is mostly a problem with the recycle bin. But proof that you can’t really rely on this as the only backup.
2. start with a brand new repo
3. edit 3 files and commit
4. edit only one of those files and commit
5. edit the three files again
6. right click on one file -> “Discard Changes”

you should see the prompt here, which I assumed was just for that one file

Expected Behavior

expected: only that file should move

Actual Behavior

actual: all my files left my repo 😦

Additional Information

to restore: open recycle bin … My recycle bin is hundreds of gigs large. I am able to locate my folder, but there’s hundreds of file changes in there, and it seems to freeze up. I’m opening an issue with Windows as well regarding the bin size.

Logs

2018-10-24.desktop.production.log

[billygriffin]

Thanks for the screenshot @toddbellMSFT, I updated the title with what I think is the issue you’re describing. Is that accurate?

@desktop/support Have you seen this before on Windows?

[billygriffin]

@toddbellMSFT Thanks for this issue and apologies for the delay in following up. I think we’re going to look at this in the context of https://github.com/desktop/desktop/issues/5342 so I’m going to close this in favor of that one. I’d like to wrap our heads around the larger UX for discarding changes especially if it continues to be something that causes people headaches. Thanks again for helping us understand the cause.