Discard changes (for a single change) is very slow
See original GitHub issueDescription
Version
- GitHub Desktop: 1.1.0
- Operating system: Windows 10 Pro 1709
Steps to Reproduce
Expected Behavior
Change should be discarded without delay.
Actual Behavior
Change is discarded, but it takes about 3 seconds for the popup to go away. This makes the UI feel very sluggish.
Additional Information
Not sure if this is just a UI issue where the popup needs to be destroyed, or if this is related to the backend / electron APIs for sending the file to the recycle bin as noted in #2629
Desktop Client system hardware specs: Dell Precision 7510 Core i7-6920HQ 32 Gigs of RAM 512 Gig SSD
Repo in that I’ve been using most recently is GitHub Enterprise. Server has 2 ms ping times and is 4 hops away on a very fast wired/gigabit corporate network:
> ping [REPO HOSTNAME]
Pinging [REPO HOSTNAME] [[REPO IP]] with 32 bytes of data:
Reply from [REPO IP]: bytes=32 time=2ms TTL=61
Reply from [REPO IP]: bytes=32 time=2ms TTL=61
Reply from [REPO IP]: bytes=32 time=2ms TTL=61
Reply from [REPO IP]: bytes=32 time=2ms TTL=61
Ping statistics for [REPO IP]:
Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
Minimum = 2ms, Maximum = 2ms, Average = 2ms
> tracert [REPO HOSTNAME]
Tracing route to [REPO HOSTNAME] [REPO IP]
over a maximum of 30 hops:
1 <1 ms <1 ms <1 ms [HOP1] [HOP1 IP]
2 2 ms 3 ms 1 ms [HOP2] [HOP2 IP]
3 <1 ms <1 ms <1 ms [HOP3] [HOP3 IP]
4 2 ms 2 ms 2 ms [REPO HOSTNAME] [REPO IP]
Running some tests for some build scripts that will ultimately change some files and check them in. For now as I’m tweaking I need to discard the changed and it’s super annoying how slow it is…
Logs
Issue Analytics
- State:
- Created 6 years ago
- Comments:10 (8 by maintainers)
Top GitHub Comments
hey @anaibol please file linux issues over in https://github.com/shiftkey/desktop. thank you!
Same issue on my machine in all repos, even the simplest ones. The old GitHub for Windows does not have this problem and discards changes instantly.