question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

enable darwinDarkModeSupport when packaging for macOS

See original GitHub issue

Please describe the problem you think should be solved

There is a new option on electron-packager which sets a flag to force Mojave builds to

darwinDarkModeSupport Boolean (default: false) Forces support for Mojave (macOS 10.14) dark mode in your packaged app. This sets the NSRequiresAquaSystemAppearance key to false in your app’s Info.plist. For more information, see the Apple developer documentation.

@JB1905 over in #7116 suggests there’s other tangible benefits:

The window frame and the top bar in full-screen mode do not adjust to the dark mode on macOS.

Do you have any potential solutions in mind?

This is the place that tracks our electron-packager config settings, where this new value should be added:

https://github.com/desktop/desktop/blob/08632922908b138da950427ad7e1ac1ce184c992/script/build.ts#L150-L196

This should also be tested by someone with Mojave to ensure the change has the desired effect.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
JB1905commented, Mar 19, 2019

With darwinDarkModeSupport: true

Zrzut ekranu 2019-03-19 o 21 54 09
1reaction
shiftkeycommented, Mar 19, 2019

@juliand665 thanks for the screenshots. Hopefully this same flag in #7119 is enough to also get those working - let’s see what we can confirm in that PR.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Safely open apps on your Mac - Apple Support
When you install Mac apps, plug-ins, and installer packages from outside the App Store, macOS checks the Developer ID signature to verify ...
Read more >
Options | electron-packager
Forces support for Mojave (macOS 10.14) dark mode in your packaged app. This sets the NSRequiresAquaSystemAppearance key to false in your app's Info.plist...
Read more >
Manual deployment for Microsoft Defender for Endpoint on ...
Download installation and onboarding packages · In Microsoft 365 Defender portal, go to Settings > Endpoints > Device management > Onboarding.
Read more >
The Missing Package Manager for macOS (or Linux ...
Paste that in a macOS Terminal or Linux shell prompt. The script explains what it will do and then pauses before it does...
Read more >
Install GitLab Runner on macOS
GitLab Runner can be installed and updated on macOS. Installing. Two methods for installing GitLab Runner on macOS are available: Manual installation.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found