enable darwinDarkModeSupport when packaging for macOS
See original GitHub issuePlease describe the problem you think should be solved
There is a new option on electron-packager
which sets a flag to force Mojave builds to
darwinDarkModeSupport
Boolean (default:false
) Forces support for Mojave (macOS 10.14) dark mode in your packaged app. This sets theNSRequiresAquaSystemAppearance
key tofalse
in your app’sInfo.plist
. For more information, see the Apple developer documentation.
@JB1905 over in #7116 suggests there’s other tangible benefits:
The window frame and the top bar in full-screen mode do not adjust to the dark mode on macOS.
Do you have any potential solutions in mind?
This is the place that tracks our electron-packager
config settings, where this new value should be added:
This should also be tested by someone with Mojave to ensure the change has the desired effect.
Issue Analytics
- State:
- Created 5 years ago
- Comments:9 (7 by maintainers)
Top GitHub Comments
With
darwinDarkModeSupport: true
@juliand665 thanks for the screenshots. Hopefully this same flag in #7119 is enough to also get those working - let’s see what we can confirm in that PR.