Enterprise sign-in: Cannot read property 'email' of undefined

Description

When signing into an Enterprise GitHub account, an error displays with Cannot read property 'email' of undefined.

Version

• GitHub Desktop: 1.3.5

• Operating system: Microsoft Windows [Version 10.0.15063]

Steps to Reproduce

• Set default web browser to Chrome (since experiencing issues with Internet Explorer / Edge when it continues to browser to authenticate)
• Download and install fresh version of GitHub Desktop (tested on 1.3.4)
• Authenticate with Enterprise credentials either during initial setup, or “skip” and then attempt to clone a repository

Expected Behavior

Expect “Continue with browser” to lead to a browser, authenticate, and then return to GitHub Desktop having signed into that user’s account.

Actual Behavior

“Continue with browser” opens new browser window, authenticates, but then when returning to GitHub Desktop the Cannot read property 'email' of undefined error is shown.

Additional Information

Logs

[mkudija]

@shiftkey thanks for the info and fix. We got it working by adding email address for the users impacted (Profile > Settings > Emails > Add email address).

[shiftkey]

@mkudija thanks for the log file, this shows you’ve been able to trip a bug that we didn’t notice before. Here’s the code on that line:

    const defaultEmail = emails[0].email || ''

Somehow, your GHE account doesn’t have any emails set, so emails[0] will be undefined. That’s The Bug™. As a workaround you may be able to add an email address to your GHE account, but we should definitely handle that better within the app.