Errors immediately following launch after 1.6.3 update

Description

I am receiving an error every time I open GitHub Desktop that says “error launching git: The filename or extension is too long” - when I close this, a “Can’t find <repository>” error message displays on the GitHub Desktop main pane (and this happens for every repository I switch to). When I switch between repositories using the dropdown menu in the top left, the error message “Git returned an unexpected exit code ‘1’ which should be handled by the caller.'” - please note that the single quote at the end of the error message is not a typo. When I press the “Locate…” button and select the repo folder, I get the same error message. When I press the “Clone Again” button and select the repo folder, I get the same error as the first one I encountered “error launching git etc…”

Version

• GitHub Desktop*: 1.6.3
• Operating system*: Windows 7 Professional (Microsoft Windows [Version 6.1.7601])

Steps to Reproduce

Nothing on my system changed except for the version update from 1.6.2 to 1.6.3 when I rebooted my computer this morning.

Expected Behavior

I expect to be able to use the GitHub Desktop application after launching.

Actual Behavior

I am unable to connect the application with any repositories via any git commands available on the application GUI.

Additional Information

I believe this is somehow related to the update from 1.6.2 -> 1.6.3 since I was not getting the error messages when 1.6.2 was running yesterday

I’ve tried uninstalling GitHub Desktop and reinstalling it, rebooting my computer, updating Git (although I now realize GH Desktop uses its own Git separate from what is designated in my PATH), running git config --system --replace-all core.longpaths true as an Administrator, and adding [core] longpaths = true to the gitconfig file located here: C:\Users\Lewis.Armistead\AppData\Local\GitHubDesktop\app-1.6.3\resources\app\git\mingw64\etc\gitconfig as a manual attempt at replicating the functionality of the previous git command.

Logs

Here is an abbreviated log from this morning showing the first error message: 2019-03-07.desktop.production.log

Looking at the logs yesterday, I noticed that the GitHub Desktop version was 1.6.2: 2019-03-06.desktop.production.log

Please note that the initial errors on 3/6 were related to my computer not being connected to the internet.

[shiftkey]

@lewisarmistead @n8all3n between 1.6.2 and 1.6.3 we upgraded the dugite package:

$ git diff release-1.6.2..release-1.6.3 -- app/package.json                                                                                        ±[shiftkey/rebase/force-push-sometimes]
diff --git a/app/package.json b/app/package.json
index 2d1331d8b..9c3de662f 100644
--- a/app/package.json
+++ b/app/package.json
@@ -3,7 +3,7 @@
   "productName": "GitHub Desktop",
   "bundleID": "com.github.GitHubClient",
   "companyName": "GitHub, Inc.",
-  "version": "1.6.2",
+  "version": "1.6.3",
   "main": "./main.js",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
     "deep-equal": "^1.0.1",
     "dexie": "^2.0.0",
     "double-ended-queue": "^2.1.0-0",
-    "dugite": "^1.80.0",
+    "dugite": "1.83.0",
     "electron-window-state": "^4.0.2",
     "event-kit": "^2.0.0",
     "file-uri-to-path": "0.0.2",

dugite@1.81.0 upgraded to Git v2.20.1 as well as Git LFS v2.6.1 - which might be a factor here. I’ve not been able to spot any regressions with these versions, but if you’re able to find versions of Git that work fine with core.longpaths enabled that’s a starting point.

I also see this issue on the Git for Windows tracker, but I’m not clear if it’s been resolved: https://github.com/git-for-windows/git/issues/2075

[JamieKeeling]

With the beta now installed I no longer encounter the issue reported.