GitHub Desktop stores password as plain text and can show it to the user
See original GitHub issueDescription
GitHub Desktop may boot and immediately show an error like line 1: keyword expected; got **password**
.
Version
GitHub Desktop version: 1.0.1
OS version: 10.12.6
Steps to Reproduce
Not reproducible; but happening consistently during startup on one client; also after updating the app.
Expected behavior: Client works as expected
Actual behavior: Client works as expected, but prints an error message on startup including the user’s password in plain text.
Reproduces how often: Every startup
Logs
Let me know if/how I can share logs discretely.
Additional Information
Issue Analytics
- State:
- Created 6 years ago
- Comments:8 (5 by maintainers)
Top Results From Across the Web
`windows_user` resource requires plaintext passwords ... - GitHub
Description The windows_user resource requires plain text passwords. The docs seem to imply it accepts crypted passwords (see docs bug) I filed, ...
Read more >Updating your GitHub access credentials
GitHub credentials include not only your password, but also the access tokens, SSH keys, ... and never stores the password you entered in...
Read more >Password should not be saved in plain text · Issue #75 - GitHub
There's nothing wrong with storing a password in plain text. The only way to really get around this is to use pubkey authentication,...
Read more >Plain text password · Issue #148 - GitHub
The password is stored in plain text in the config file. Is there any chance to store a hashed version of the password?...
Read more >Credentials are stored in plain text · Issue #854 - GitHub
Passwords ? Aren't these personal access tokens that are automatically issued when you authenticate? GCM shouldn't hash anything unless it ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@BasThomas I’m going to close this out as I think we know the root cause - please feel free to comment (either here or over email) if there’s anything more to add.
I’ll check!
Sent with GitHawk