Increase height of the Commit Summary area to avoid the use of the Expand button
See original GitHub issueSo the height of the commit-summary-description-container
is not optimal. Although we created the shadow to let the user know there is more info below (see here 👇)
I think we ought to increase the height of this area by a few pixels to avoid the following scenario.)
Before user clicks expand:
After user clicks expand:
Literally, I clicked the Expand
button to remove the shadow from the sentence. The latter pic seems like a reasonable minimal height… and if there is any text below then we should show the shadow.
1.4.1-beta0, mac
Issue Analytics
- State:
- Created 5 years ago
- Comments:9 (9 by maintainers)
Top Results From Across the Web
Ability to increase height of commit area · Issue #1745 - GitHub
Feature request: ability to drag the commit message area and increase its height, and save it so that I don't have to keep...
Read more >Avoid button height expanding due to other ... - Stack Overflow
What I want to achieve : Increase the height of the rightButton(Second Button) but keep the height of the leftButton(First Button) as is....
Read more >Expand/Collapse (based on Details/Summary)
The summary element is the button that controls the expand/collapse action. The details element contains the content that is hidden or shown as...
Read more >Commit Changes dialog | IntelliJ IDEA Documentation
Use this dialog to commit (check in) local changes to the ... Click these buttons to expand or collapse all nodes in the...
Read more >Visual Studio Code June 2022
Tasks that have the kind property set to test , use the beaker icon by default. Source Control. Commit "action button" for Git...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I think when it’s only 3 lines we can just show them. Then once it hits 4 lines, we still cap it at 3, show the shadow and the expand button, and expand to see lines 4+. This way, we only show the shadow when you’re actually going to be expanding to see more lines. Do we think that’s technically feasible?
@ampinsk I think so. @aryyya has done some similar work for the commit summary box recently in https://github.com/desktop/desktop/pull/5513. any thoughts @aryyya?