question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Increase height of the Commit Summary area to avoid the use of the Expand button

See original GitHub issue

So the height of the commit-summary-description-container is not optimal. Although we created the shadow to let the user know there is more info below (see here 👇)

https://github.com/desktop/desktop/blob/3756c147716a2f26729dd790a9cba6a4033fe232/app/styles/ui/history/_commit-summary.scss#L47

I think we ought to increase the height of this area by a few pixels to avoid the following scenario.)

Before user clicks expand: screen shot 2018-09-20 at 3 42 20 pm

After user clicks expand: screen shot 2018-09-20 at 3 42 33 pm

Literally, I clicked the Expand button to remove the shadow from the sentence. The latter pic seems like a reasonable minimal height… and if there is any text below then we should show the shadow.

cc @desktop/design

1.4.1-beta0, mac

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

4reactions
ampinskcommented, Sep 21, 2018

I think when it’s only 3 lines we can just show them. Then once it hits 4 lines, we still cap it at 3, show the shadow and the expand button, and expand to see lines 4+. This way, we only show the shadow when you’re actually going to be expanding to see more lines. Do we think that’s technically feasible?

2reactions
outofambitcommented, Sep 21, 2018

@ampinsk I think so. @aryyya has done some similar work for the commit summary box recently in https://github.com/desktop/desktop/pull/5513. any thoughts @aryyya?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Ability to increase height of commit area · Issue #1745 - GitHub
Feature request: ability to drag the commit message area and increase its height, and save it so that I don't have to keep...
Read more >
Avoid button height expanding due to other ... - Stack Overflow
What I want to achieve : Increase the height of the rightButton(Second Button) but keep the height of the leftButton(First Button) as is....
Read more >
Expand/Collapse (based on Details/Summary)
The summary element is the button that controls the expand/collapse action. The details element contains the content that is hidden or shown as...
Read more >
Commit Changes dialog | IntelliJ IDEA Documentation
Use this dialog to commit (check in) local changes to the ... Click these buttons to expand or collapse all nodes in the...
Read more >
Visual Studio Code June 2022
Tasks that have the kind property set to test , use the beaker icon by default. Source Control. Commit "action button" for Git...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found