question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

It's unclear which branch is being merged into another in the merge dialog

See original GitHub issue

The directional merge flow is not as obvious as it could be. It should be perfectly clear which branch you’re merging into which branch.

⚠️ See #5555 for additional context ⚠️

This issue is marked as help wanted to gives others the chance to get involved in feature iteration.

Current Merge Dialog screen shot 2018-10-17 at 4 42 51 pm Note that we are merging git-store-cache into master.

Goal

We want to make it clearer what branch will be merged into another.

Proposed Solution

Make two changes:

  1. use the title of the dialog to state what branch is being merged and the direction it’s being merged
  2. Move the conflicts hint above the Merge button

Mockup 46981644-233e0280-d08e-11e8-9a17-c76e9dca38b5-2

Risks

  • Branch names can be an arbitrary length, so it’s worth thinking about how to present a longer branch names in a fixed width window.

The CSS that controls the ellipsis is located here: https://github.com/desktop/desktop/blob/19d5fdd4621c6147979c3ac3fdbc77c89d8d4d6a/app/styles/ui/_branches.scss#L204-L217 for some prior art in that area.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:3
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

4reactions
JQuinniecommented, Oct 17, 2018

Hi, I’d like to take a stab and work on this issue, thanks!

2reactions
tierninhocommented, Oct 22, 2018

Maybe this issue should be addressed here too? https://github.com/desktop/desktop/issues/5970

Secondly, should we edit the merge hint text “This branch is up to date with…” with the actual branch name? It will match our other iterations. This is in regards to https://github.com/desktop/desktop/blob/aa99aa3aceba96f3b8b9e793334b9c9346dc17ec/app/src/ui/merge-branch/merge.tsx#L183

Read more comments on GitHub >

github_iconTop Results From Across the Web

Conflict Resolution in Merge Request reverses merge direction
Because the branch will not be deleted automatically after being merged, it is safe to open merge requests between two long-running branches.
Read more >
How to specify the branch you want to merge to on GitLab?
You have a "change branches" link on the top of the GUI. Click it, and choose the branch you want to merge in...
Read more >
Git Merge Dialog - IntelliJ IDEA Guide - JetBrains
A common cause of merge conflicts is when you're working on a feature branch while other changes have been applied to the main...
Read more >
Merging, conflicts and deleting branches with Brackets-Git
This is something new, we haven't merged a branch with Brackets yet, this is how you do it. I want to merge the...
Read more >
Merge or Rebase? | SourceTree Blog
Existing commits on the source branch are unchanged and remain valid; it doesn't matter if they've been shared with others. Merging Cons. If...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found