Line endings change warning phrasing is backwards

Description

The warning that line endings for a file have changed has it backwards, saying the file’s line endings have change from “what it is now” to “what it was”, instead of vice versa. See screenshot below illustrating the problem. This confused me for a bit when it first happened.

Version

• GitHub Desktop: 1.4.0

• Operating system: Windows 10 Pro x64 [10.0.17134.285]

Steps to Reproduce

• Change the line endings of a file
• View diff in GitHub Desktop
• Note that change described in warning text is backwards

Expected Behavior

The warning to say “Line endings have changed from ‘CRLF’ to ‘LF’”

Actual Behavior

The warning actually says “Line endings have changed from ‘LF’ to ‘CRLF’”

[fatcerberus]

FWIW it seems to be an impedance mismatch between Desktop and Git: Git is warning “I’m going to change the line endings when I make the commit” while Desktop is misappropriating that message to mean “the line endings have changed from what they were before”—which is not (necessarily) true.

[fatcerberus]

Based on that third line, it seems that it’s deciding how to warn based on the message from git diff–a message which is itself pretty confusing. Git’s warning actually means something closer to “(CRLF|CR|LF) in the working tree will be replaced with (CRLF|CR|LF) in the repo when committed”. In other words it’s not necessarily telling you that the file’s line endings changed (although in practice this is usually the case), but rather that the line endings in the working tree simply don’t match what Git has been configured to commit.