Linux naming

Description

In many places there’s the assumption that if the OS is not macOS, then it’s Windows. An example can be found at app/src/lib/editors/lookup.ts:

const menuItemName = __DARWIN__ ? 'Preferences' : 'Options'

I think an assumption like this one it’s okay, because I’m not aware of a cross-de conventions about which name to use for settings 😁.

But in other places, it’s less great. The real “issue” for me it’s “Explorer”. For example, in app/src/ui/changes/no-changes.tsx:

const opener = __DARWIN__ ? 'Finder' : 'Explorer'

I don’t think there’s a fast way to synchronously get the default file manager name on Linux.

Visual Studio Code, for example, avoids this issue saying Open Containing Folder, I don’t know what it shows for macOS and Windows.

Maybe your File Manager could be just fine.

Version

GitHub Desktop version: [1.0.5-test1]

OS version: [Fedora 26]

Steps to Reproduce

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Reproduces how often: [What percentage of the time does it reproduce?]

Logs

Additional Information

[niik]

I might be in the minority here, but I still see these solutions as heavier than the problem itself. Conditionals are a bummer, but trading them for more complexity isn’t a net win, I don’t think.

💯

Let’s not overthink this until it becomes a problem for real (l18n). For now adding one more condition seems like the most straightforward approach to the problem that this issue is referring to.

const opener = __DARWIN__ ? 'Finder' : 
               __WINDOWS__ ? 'Explorer' :
               'your File Manager'

[joshaber]

I might be in the minority here, but I still see these solutions as heavier than the problem itself. Conditionals are a bummer, but trading them for more complexity isn’t a net win, I don’t think.