Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Low contrast for colours in diff/Changes

See original GitHub issue

Description

The red/green diff colours have a very low-visibility contrast, making them hard to spot. As a related bug-fix/feature request I would like for the app to honour the Accessibility settings for increased contrast which should make borders more pronounced.

See the attached image below where the Desktop app (on macOS) has the least contrast of the tree compared services.

screen shot 2017-08-30 at 15 58 09

Version

GitHub Desktop version: 0.8.0

OS version: macOS 10.12.6 (16G29)

Steps to Reproduce

View the Changes of a file.

Expected behavior: Good, readable, contrasty colours.

Actual behavior: User squints all the time to see the colours. 😃

Reproduces how often: Every time

Logs

n/a

Additional Information

n/a

Issue Analytics

State:
Created 6 years ago
Reactions:4
Comments:6 (4 by maintainers)

Top GitHub Comments

2reactions

donokudacommented, Aug 30, 2017

I agree. We should sync up our diff colors with what we use on the site given that they’ve chosen the colors with accessibility in mind.

As a related bug-fix/feature request I would like for the app to honour the Accessibility settings for increased contrast which should make borders more pronounced.

I’d be interested to see if this is possible with Electron. If so, then we could override the border color with a darker value.

0reactions

adamreisnzcommented, Oct 11, 2017

@niik Thanks for the work on this item and for increasing the contrast. 🎉 Are you able to also have a quick look at the font thickness/color and see if you could bump that a bit darker as well (see above screenshots)?