`NAME` is recognized instead of `NAME.github.io`

Describe the bug

If you personally have the repositories NAME.github.io and NAME , adding NAME.github.io will recognize NAME instead.

Version & OS

• GitHub Desktop Version 2.6.2
• Windows 10 Home Version 20H2

Steps to reproduce the behavior

You can reproduce this using Organization instead of a personal account

1. generates repositories NAME.github.io
2. Rename the repository of NAME.github.io to NAME (e.g. Repository page - Settings)
3. generates repositories NAME.github.io again
4. Select Add and add NAME.github.io on GitHub Desktop.
5. Make sure the listed repositories are NAME instead of NAME.github.io

Expected behavior

Screenshots

Until recently I was successfully using fu-sen.github.io on GitHub Desktop. It was encountered with the addition of fu-sen.

But fu-sen.github.io/.git/config successfully references fu-sen.github.io (Refer to the folder (directory) in the title bar):

I added 2 repositories to Sourcetree and it’s fine:

Note: I’m Japanese, so I see a ￥ instead of a＼

Actual behavior

Even if you encounter this problem, local Push etc. can be reflected in the repository USER.github.io.

But if you add the repository from GitHub Desktop, you will get the USER repository instead of USER.github.io. This can be avoided by other means, such as git clone from the CLI.

Logs

It contains an automatic update error, but paste it as is.

2021-01-23T02:36:14.361Z - info: [ui] [AppStore] loading 63 repositories from store
2021-01-23T02:36:14.362Z - info: [ui] [AppStore] found account: fu-sen (BALLOON | FU-SEN)
2021-01-23T02:36:14.693Z - info: [ui] [BranchPruner] Last prune took place in a day - skipping
2021-01-23T02:36:14.794Z - info: [ui] launching: 2.6.2 (Windows 10.0.19042)
2021-01-23T02:36:14.795Z - info: [ui] execPath: 'C:\Users\balloon\scoop\apps\github\current\GitHubDesktop.exe'
2021-01-23T02:36:14.907Z - error: [ui] Error checking for updates
Error: The application is missing a dependency it needs to check and install updates. This is very, very bad.
    at file:///C:/Users/balloon/scoop/apps/github/2.6.2/resources/app/renderer.js:45:170322
    at onAutoUpdaterError (file:///C:/Users/balloon/scoop/apps/github/2.6.2/resources/app/renderer.js:45:170738)
    at CallbacksRegistry.apply (electron/js2c/renderer_init.js:131:792)
    at electron/js2c/renderer_init.js:83:5068
    at EventEmitter.<anonymous> (electron/js2c/renderer_init.js:83:4308)
    at EventEmitter.emit (events.js:223:5)
    at Object.onMessage (electron/js2c/renderer_init.js:115:818)
2021-01-23T02:36:20.947Z - info: [ui] Executing fetch: git -c credential.helper= -c protocol.version=2 fetch --progress --prune origin (took 1.615s)
2021-01-23T02:36:30.523Z - info: [ui] [BranchPruner] Last prune took place in a day - skipping
2021-01-23T02:36:35.112Z - info: [ui] [BranchPruner] Last prune took place in a day - skipping
2021-01-23T02:36:41.863Z - info: [ui] Executing getStatus: git --no-optional-locks status --untracked-files=all --branch --porcelain=2 -z (took 2.006s)
2021-01-23T02:36:43.538Z - info: [ui] Executing getStatus: git --no-optional-locks status --untracked-files=all --branch --porcelain=2 -z (took 1.191s)
2021-01-23T02:36:45.387Z - info: [ui] Executing getStatus: git --no-optional-locks status --untracked-files=all --branch --porcelain=2 -z (took 1.335s)
2021-01-23T02:37:02.692Z - info: [ui] [Timing] Action 'create commit' for 'fu-sen/fu-sen' took 2.110s
2021-01-23T02:37:02.714Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: fu-sen - fu-sen (has token)
2021-01-23T02:37:08.361Z - info: [ui] Executing push: git -c credential.helper= -c protocol.version=2 push origin main:main --progress (took 5.494s)
2021-01-23T02:37:10.185Z - info: [ui] Executing fetch: git -c credential.helper= -c protocol.version=2 fetch --progress --prune origin (took 1.681s)
2021-01-23T02:37:18.389Z - info: [ui] [RepositoryIndicatorUpdater]: Refreshing sidebar indicators for 62 repositories took 45.5s of which 0.0s paused, total 45.5s
2021-01-23T02:37:50.373Z - info: [main] opening in browser: https://github.com/fu-sen/fu-sen
2021-01-23T02:38:31.372Z - info: [ui] Executing fetch: git -c credential.helper= -c protocol.version=2 fetch --progress --prune origin (took 1.611s)
2021-01-23T02:38:43.829Z - info: [ui] [AppStore] adding repository at C:\Users\balloon\Dropbox\GitHub-balloon.vg\fu-sen.github.io to store
2021-01-23T02:38:44.816Z - info: [ui] [BranchPruner] Last prune took place in a day - skipping
2021-01-23T02:38:50.635Z - info: [ui] [BranchPruner] Last prune took place in a day - skipping
2021-01-23T02:38:52.542Z - info: [ui] Executing fetch: git -c credential.helper= -c protocol.version=2 fetch --progress --prune origin (took 1.745s)
2021-01-23T02:38:53.628Z - info: [ui] [BranchPruner] Last prune took place in a day - skipping

Additional context

For personal accounts, NAME has become a special repository. Therefore, when you rename from Personal GitHub Page and generate a special repository, you are more likely to encounter the bug.

The same issue was reported before, but it seems I couldn’t reproduce it: https://github.com/desktop/desktop/issues/8425

This may be encountered only for some users or OS (Windows).

[sergiou87]

Thank you for your report @fu-sen !!

I tried on Windows and macOS but I haven’t been able to reproduce this issue. Could you also show us how you add the repo to GitHub Desktop? Did you have the fu-sen/fu-sen repo already in the app?

A video of the whole process would be very helpful too.

[sergiou87]

I think this should’ve been fixed by #12308 😄