"Open in Atom" menu item despite Atom not being installed

Description

The Repository menu presents me with the Open in Atom option despite Atom not being installed.

When I click it, I get an error message:

In the configuration, only VSCode and Sublime are available (which is correct, both are installed). VSCode seems to be selected, but as indicated by the menu item, it’s not internally / in GitHub Desktop’s config.

Selecting Sublime and switching back to VSCode fixes it:

Version

GitHub Desktop version: 0.8.0 OS version: Microsoft Windows [Version 10.0.15063]

Steps to Reproduce

1. Install GitHub Desktop (or clear the local storage files in AppData\Roaming\GitHub Desktop\Local Storage)
2. Open the Repository menu
3. Observe the non-functional Open in Atom menu

Expected behavior: the menu item should match the selected external editor in Options -> Advanced with a fresh config Actual behavior: it’s always Atom

Reproduces how often: 100%

Additional Information

Atom used to be installed on my system, so maybe something is left-over that makes GitHub Desktop think it’s still around. This seems unlikely as it’s not presented in the external editor dropdown-menu however.

[shiftkey]

@tierninho @j-f1 well it seems to be failing as expected here (we check that the Atom shim exists before launching), so I’m not sure that one is something we can fix in Desktop.

[shiftkey]

@coaperator please have a read of our documentation around the editor integration.