Open/add local repo from command line should not prompt for approval

Description

If I’m adding a repo from the command line, the path is most likely correct and I have already made my decision to add it. I do not want to have to confirm a dialog box.

This would also help with automation

Version

• GitHub Desktop: 1.1.0

• Operating system: macOS 10.13.3

Steps to Reproduce

github open “/users/matt/projects/test”

Expected Behavior

Should just add it if it’s a valid local repo

Actual Behavior

I have to confirm a dialog accepting the values I know are correct because i passed them to the app

Alternatively, an add command could be added to the github command line app.

[shiftkey]

I meant that another app/website could make a similar URL, and if we bypassed user approval when the URL is called, arbitrary code could be downloaded onto the user’s computer.

This is what currently happens in Desktop when you provide a URL rather than a path:

I don’t think the proposed change here to add the valid repository that exists on disk changes this behaviour (which isn’t ideal).

[shiftkey]

As part of this workflow we already check if this path is associated with a tracked repository, and select that to avoid confusion:

https://github.com/desktop/desktop/blob/1b96ce51c752cc077b53a4ad01052f16ce1905b2/app/src/lib/dispatcher/dispatcher.ts#L841-L848

I think I’d be 👍 to adding the repository if:

• it comes from the open-repository-from-path code path (i.e. the user initiated this from the CLI)
• is a valid Git repository

Otherwise we should end up on this path, with details about why we need user input.

cc @desktop/core @desktop/comrades for feels