question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

padding issue with emoji/user/issue autocomplete forms

See original GitHub issue

Description

image

Version

  • GitHub Desktop: 1.6.3-beta1
  • Operating system: macOS

Steps to Reproduce

Use the : in the commit summary to trigger the emoji selection.

Expected Behavior

Emoji icon has padding on left-hand side

Actual Behavior

Emoji is squished against left edge

Additional Information

I believe this is related to our Electron 3 upgrade in #6713 so you might not notice this in the current production build.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
tierninhocommented, Feb 20, 2019

Both the # and @ autocompletion-popup are also affected.

2reactions
niikcommented, Feb 21, 2019

I believe this is related to our Electron 3 upgrade in #6713 so you might not notice this in the current production build.

This got me anxious since bumping Chromium really shouldn’t affect styling, they take incredible care not to regress in this area so I felt the need to go digging and it turns out that this was simply an unexpected side-effect of another change where a little overly ambitious CSS selector matched too greedily. The change was https://github.com/desktop/desktop/commit/83ddcf0f82ceafb2d50a4589488b60d868a8e0ab#diff-5c3655a73143215d8edebe5ad471326b where .file-list .list-item had its padding removed and it turns out that .file-list isn’t actually a list but a rather all-encompassing wrapper in the sidebar meaning that any list item underneath that was affected by the same style.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Trouble while applying padding in form element - Stack Overflow
This is a snapshot of a basic form webpage, while changing the values of padding the gray background is not shrinking.
Read more >
Padding issue on mobile version of form - Jotform
On this form I need to reduce padding so that "Photo Prints" sits right under carousel.Here is the form itself: ...
Read more >
Autofill's undesired behaviour - p… | Apple Developer Forums
Here's a problem we're trying to solve right now, we have an input field that ... .autocomplete-honeypot { float: left; display: inline-block; padding:...
Read more >
autofill - CSS: Cascading Style Sheets - MDN Web Docs
The :autofill CSS pseudo-class matches when an element has its value autofilled by the browser. The class stops matching if the user edits ......
Read more >
Place Autocomplete | Maps JavaScript API - Google Developers
The radio buttons allow you to filter the types of predictions that the autocomplete returns. The Strict Bounds option restricts the search to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found