Protected branch restrictions ignored when merging from desktop app
See original GitHub issueDescription
I am able to merge code directly into master
from the desktop tool, despite master
being a protected branch in our repo that requires both a code review and passing ci tests.
Version
GitHub Desktop version: 1.0.11 OS version: MacOS
Steps to Reproduce
- Create a branch that tracks an upstream protected branch
- From the GitHub desktop UI, push to origin
- Branch bypasses protections and merges into upstream branch
Expected behavior: Fail, or warn about protected branch restrictions
Actual behavior: Merges branch automatically into protected upstream branch
Reproduces how often: 100%
Logs
NA
Additional Information
I have admin permissions in the repo, however in the website UI I am forced to opt-in to override branch protections in order by bypass them with privilege. From the desktop application, I am not warned or restricted from merging into protected branches, regardless of CI states or reviewer status.
Issue Analytics
- State:
- Created 6 years ago
- Comments:7 (5 by maintainers)
Top Results From Across the Web
Set Up Branch and Merge Restrictions | JetBrains Space ...
Open the Repository Settings page and go to the Protected Branches tab: · Click New rule to open the form. · Specify main...
Read more >Sourcetree seems to ignore protected branch rules
Now, in SourceTree, I can still merge a feature branch into both develop and main without a pull request, using the [right click...
Read more >Best Practices for Branch Protection - YouTube
Branch protection is part of a powerful set of configuration options that give repository administrators the ability to enforce security ...
Read more >Merge conflicts - GitLab Docs
GitLab does not detect conflicts when both branches rename a file to different names. For example, these changes don't create a conflict: On...
Read more >Git branch policies and settings - Azure Repos - Microsoft Learn
Branch policies help teams protect their important branches of development. ... For more information, see Set Git repository permissions.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@workobots reported in #4444 that even committing to
master
may be covered by branch protections, and while pushes are blocked this is a chance for the app to catch and warn users at commit time and guide them to the ideal workflow.This idea is interesting for the future, but this is beyond the scope of our current roadmap.
I added the
future-proposal
label to this issue and closed it so that we won’t get overwhelmed with our backlog! We will revisit this in our next planning session.