Revert dialog doesn't handle keyboard input as expected (reverts when you may mean cancel)

I’m fairly new to Mac OS so I may have misunderstood this, but I believe that <enter> is supposed to always accept “the blue button” and <space> accepts the “blue-bordered-item” which can be tabbed through.

On this dialog, if I tab to the “Discard changes” button and then press either <enter> or <space> it still seems to discard, but I expected one to cancel.

[DanTup]

I’m a little confused - the linked comment suggests you want to follow macOS, but that doesn’t seem to be what’s happening. On macOS, <enter> does not do the button highlighted with <tab>, it does the blue/default button.

(I’m also not sure about the reviewer-needs-to-reproduce label?)

[billygriffin]

Totally agree with your critique, it’s completely valid. We went back and forth on it and agree that there’s not a great answer, but ultimately decided that since Cancel will close the dialog, that behavior will be super confusing as well, and since it requires that a user explicitly tabs to the particular button prior to the click, they’ve signaled their intent sufficiently enough to depart from the macOS behavior in this very narrow case. Thanks again for the issue, it really helped us understand how to think about it.