Show Repository List menu option also hides the list

The Show Repository list menu option (⌘T) shows the list as intended, when selected, but it also hides the list, which should be disabled. The other menu selections under the View top-level nav do not function the same, so all actions should be uniform.

Also, the repo list should close if the user selects either Show Changes or Show Branches from the View menu. Currently they open in the background, behind the Repository list.

tested 0.8.1-beta3, mac

[shiftkey]

I think we should only worry abou Show/Hide Branch List and Show/Hide Repositories List for these menus. Show Changes and Show History should hide the active popover, if any exists. I say this because Hide Changes or Hide History don’t make sense from a navigation perspective.

[JordanMussi]

I’m inclined to say that all of those “Show X” menu items should really toggle their foldout.

Agreed.

I think we should only worry abou Show/Hide Branch List and Show/Hide Repositories List for these menus. Show Changes and Show History should hide the active popover, if any exists. I say this because Hide Changes or Hide History don’t make sense from a navigation perspective.

No need to worry about the first two either since when you open a menu foldout the open foldout is closed. So you can’t have a situation where you have the View menu open when the repositories/branches list foldout is open.