Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"squash and merge" commit message doesn't render clickable link

See original GitHub issue

Is your feature request related to a problem? Please describe. Currently this app only parse pr number from normal merge commit. https://github.com/desktop/desktop/blob/72e87e23d3c8d5fd3ea9c6ab04f0f03b01968f38/script/changelog/parser.ts#L16-L21

It’d be nice to parse pr number from squash and merge commit too. Suggestion regex /$#(\d+)$$/ e.g. Update README.md (#123)

If this is accepted, i can help to contribute if team don’t have time.

Thanks.

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

shiftkeycommented, Jul 20, 2018

@1pete aha, now I’m with you.

Any suggestion?

Not currently, but we have a bunch of tests in app/test/unit/text-token-parser-test.ts to catch regressions - here’s an example you can use in reference to reproduce this issue for that style of commit message:

https://github.com/desktop/desktop/blob/0ec5b64ed393efbe43fb58abef39b43d83a9e12d/app/test/unit/text-token-parser-test.ts#L168-L190

0reactions

shiftkeycommented, Jul 20, 2018

@1pete I’ve updated the title to reflect the right context, and labelled this as a bug because it affects existing repositories