Sublime Text 3 not shown as external editor

Describe the bug

Cannot detect Sublime Text 3 as the external editor even though it has been installed.

Version & OS

GitHub Desktop version - Version 2.9.4 (x64)

OS Version - macOS Catalina 10.15.7 (19H1519)

Steps to reproduce the behavior

1. Go to Preferences > Integrations > External Editor
2. “Sublime Text” does not show up there, even though it has been installed

Expected behavior

Expect “Sublime Text” to show up there in Preferences > Integrations > External Editor, and expect it to be invoked properly

Actual behavior

No “Sublime Text” in Preferences > Integrations > External Editor.

Screenshots

^ the above screenshot shows that Sublime Text is not listed as the external editor

^ the above screenshot shows that Sublime Text has been installed in Applications

Logs

2021-11-20T00:18:47.854Z - info: [ui] [AppStore] loading 22 repositories from store
2021-11-20T00:18:47.855Z - info: [ui] [AppStore] found account: aafulei (Aaron Fu Lei)
2021-11-20T00:18:47.912Z - info: [ui] [BranchPruner] Last prune took place in 13 hours - skipping
2021-11-20T00:18:48.376Z - info: [ui] launching: 2.9.4 (Mac OS 10.15.7)
2021-11-20T00:18:48.377Z - info: [ui] execPath: '/Applications/GitHub Desktop.app/Contents/Frameworks/GitHub Desktop Helper (Renderer).app/Contents/MacOS/GitHub Desktop Helper (Renderer)'
2021-11-20T00:19:41.176Z - info: [ui] [AppStore] loading 22 repositories from store
2021-11-20T00:19:41.177Z - info: [ui] [AppStore] found account: aafulei (Aaron Fu Lei)
2021-11-20T00:19:41.242Z - info: [ui] [BranchPruner] Last prune took place in 13 hours - skipping
2021-11-20T00:19:41.702Z - info: [ui] launching: 2.9.4 (Mac OS 10.15.7)
2021-11-20T00:19:41.702Z - info: [ui] execPath: '/Applications/GitHub Desktop.app/Contents/Frameworks/GitHub Desktop Helper (Renderer).app/Contents/MacOS/GitHub Desktop Helper (Renderer)'
2021-11-20T00:22:12.460Z - info: [ui] [RepositoryIndicatorUpdater]: Refreshing sidebar indicators for 21 repositories took 9.0s of which 0.0s paused, total 9.0s

Additional context

The Sublime Text 3 version is the latest build for Version 3, i.e. Version 3.2.2 Build 3211.

It was installed as /Applications/Sublime Text.app in the standard way, i.e. drag and drop after clicking the .dmg file acquired from the official website.

$ mdls -name kMDItemCFBundleIdentifier -r /Applications/Sublime\ Text.app
com.sublimetext.3

$ readlink `which subl`
/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl

[steveward]

@aafulei thanks for the update. I was also able to reproduce this by uninstalling Sublime Text 4 and then installing the latest Sublime Text 3.

You can read how our editor integration works here:

https://github.com/desktop/desktop/blob/development/docs/technical/editor-integration.md

It is helpful to know that Sublime Text was previously detected – this looks similar to issues reported in https://github.com/desktop/desktop/issues/13089. In that specific case Sublime Text showed up again after a period of time. I’ll test a few things out to see if I can figure out what’s going on here.

[aafulei]

Another issue was opened about this in #14197 with further details, so I’m going to close this out in favor of that one. @aafulei there’s a workaround in #14197 that you could follow to get Sublime Text 3 working.

Thank you @steveward. Just noticed your message and just tried the workaround there, i.e. removing 'com.sublimetext.4' from /Applications/GitHub Desktop.app/Contents/Resources/app/renderer.js. I happily confirm that it works!

Sadly I would like to mention that this fix does not seem to last beyond any upgrade. That is, after an upgrade, the renderer.js will be reset and 'com.sublimetext.4' seems to reappear again 🙀🙀