Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Successful merge banner appears when a merge doesn't actually happen

See original GitHub issue

Description

Successful merge banner appears when clicking Update from master and it doesn’t take into account if an actual merge occurs.

Version

GitHub Desktop: 1.5.1-beta0
Operating system: 10.14.1 (18B75) - Mojave

Steps to Reproduce

Find a branch that is up to date with master
Click update from master from branch menu
Observe that the banner appears even though a merge didn’t occur

Expected Behavior

The banner shouldn’t appear when a merge don’t actually happens

Actual Behavior

The banner appears either way

Additional Information

merge_banner_appears_in_the_wrong_time

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:14 (14 by maintainers)

Top GitHub Comments

3reactions

ampinskcommented, Jan 14, 2019

Ooh I was thinking in the same banner area and it would disappear. Keeping the check would possibly still make sense as well.

1reaction

niikcommented, Jul 1, 2022

It says “This branch is already up to date with {default branch name}.” It has a green check to the left of it in the same way as the success banner does.

This was fixed in https://github.com/desktop/desktop/pull/10453